You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1) Overloaded checklattice for two LocalOperators
2)Changed LocalOperator+LocalOperator such that its more efficient when duplicate indices appear
3)Defined Number*LocalOperator
4)Defined - using + and *
It might be useful to also check when H1 - H2 contains operators that are 0 that can therefore be thrown away.
The issue is that this requires some sort of tolerance which is a bit ambiguous.
Any suggestions/preferences ? Or do we just ignore this subtlety ?
Honestly, maybe we just add a default tolerance for that? something like norm < eps^(3/4) (1e-12) sounds reasonable to me.
I think the cleaner approach is then to just ignore this in the + methods, and just handle this in the constructor (where we can have the tolerance as a kwarg).
1) Extended LocalOperator constructor so that it eliminates operators with norm < tolerance.
2) Used this to make + - * implementations more streamlined
I made some slight changes and added a very basic docstring, thanks for getting this started!
Once the tests turn green, I think this is good to go from my side.
I made some slight changes and added a very basic docstring, thanks for getting this started! Once the tests turn green, I think this is good to go from my side.
This all looks great for me. And you're welcome ! :)
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I defined addition for Localoperators