This repository has been archived by the owner on Jul 24, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 69
Added close_session #762
Merged
Merged
Added close_session #762
Changes from 3 commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
9287820
Added close_session
merav-aharoni 9acbb48
black
merav-aharoni 07b5db2
Merge branch 'main' into close_session
merav-aharoni ee54940
Added implementation for closing a session + test
merav-aharoni 6dcf23b
Merge branch 'close_session' of github.com:merav-aharoni/qiskit-ibm-p…
merav-aharoni a26f603
add self url
kt474 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
self.provider._runtime_client.cancel_session
doesn't exist in this repo so it'll have to be added there as wellThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are right, I shouldn't have submitted for review so quickly. I copied the implementation from
runtime
. Also added a test, though it is pretty trivial. We will unite this functionality back when uniting the two repos.