This repository has been archived by the owner on Jul 24, 2024. It is now read-only.
Added close_session #762
Merged
Added close_session #762
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
13 tasks
Pull Request Test Coverage Report for Build 6689794076
💛 - Coveralls |
kt474
reviewed
Oct 30, 2023
| if self._session: | ||
| self._session.cancel() | ||
| if self._session.session_id: | ||
| self.provider._runtime_client.cancel_session(self._session.session_id) |
There was a problem hiding this comment.
self.provider._runtime_client.cancel_session doesn't exist in this repo so it'll have to be added there as well
There was a problem hiding this comment.
You are right, I shouldn't have submitted for review so quickly. I copied the implementation from runtime. Also added a test, though it is pretty trivial. We will unite this functionality back when uniting the two repos.
kt474
approved these changes
Oct 30, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Added
IBM_Backend.close_sessionin additionIBM_Backend.cancel_session.Details and comments
Requested in the review of Qiskit/qiskit-ibm-runtime#1138.