Link checker: Qiskit legacy release notes in a single FileBatch #881
Conversation
|
Thanks for contributing to Qiskit documentation! Before your PR can be merged, it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient. Thanks! 🙌 |
scripts/commands/checkLinks.ts
Outdated
|
|
||
| return await FileBatch.fromGlobs( | ||
| toCheck, | ||
| [`docs/api/qiskit/0.45/*`], |
There was a problem hiding this comment.
Does this pass for current code? I think you will want to move the code you currently have marked as TODO to instead apply here.
There was a problem hiding this comment.
Yes, good catch! I have added it there and I will remove it in my other PR 👍
|
|
||
| return await FileBatch.fromGlobs( | ||
| toCheck, | ||
| // Temporary - remove after https://github.com/Qiskit/documentation/pull/865 is merged |
There was a problem hiding this comment.
I think you can remove this from where you had it before?
There was a problem hiding this comment.
Yeah, I was double checking everything. The only link we need to load is docs/api/qiskit/release-notes/index.md
|
PR description is out of date btw |
Fixes a bug in #881. It handled `--qiskit-release-notes` correctly, but it incorrectly would skip `--historical-apis` for Qiskit versions before 0.45. This also loads fewer files for the migration guides.
…it#881) The legacy release notes of qiskit were generated from qiskit 0.45 and we need to check them loading those docs. This PR groups together all the legacy release notes in a FileBatch to avoid loading the same docs multiple times.
Fixes a bug in Qiskit#881. It handled `--qiskit-release-notes` correctly, but it incorrectly would skip `--historical-apis` for Qiskit versions before 0.45. This also loads fewer files for the migration guides.
The legacy release notes of qiskit were generated from qiskit 0.45 and we need to check them loading those docs. This PR groups together all the legacy release notes in a FileBatch to avoid loading the same docs multiple times.