Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix logic for checking historical Qiskit docs #889

Merged
merged 1 commit into from
Feb 26, 2024

Conversation

Eric-Arellano
Copy link
Collaborator

Fixes a bug in #881. It handled --qiskit-release-notes correctly, but it incorrectly would skip --historical-apis for Qiskit versions before 0.45.

This also loads fewer files for the migration guides.

Copy link
Collaborator

@arnaucasau arnaucasau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! Thank you for fixing this Eric! Tested locally, and now it checks all historical versions

@Eric-Arellano Eric-Arellano added this pull request to the merge queue Feb 26, 2024
Merged via the queue into main with commit 7e97535 Feb 26, 2024
2 checks passed
@Eric-Arellano Eric-Arellano deleted the EA/fix-link-checker-historical branch February 26, 2024 19:01
frankharkins pushed a commit to frankharkins/documentation that referenced this pull request Jul 22, 2024
Fixes a bug in Qiskit#881. It
handled `--qiskit-release-notes` correctly, but it incorrectly would
skip `--historical-apis` for Qiskit versions before 0.45.

This also loads fewer files for the migration guides.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants