-
-
Notifications
You must be signed in to change notification settings - Fork 465
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: ForumChannel default_reaction_emoji attribute #2178
feat: ForumChannel default_reaction_emoji attribute #2178
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
edit
and create
methods could accept a string representation of the emoji (<a:emoji_name:emoji_id>
) for convenience, similarly to how Message.add_reaction
accepts a string repr of a custom emoji (although it's implemented differently due to how the endpoint works)
other than that lgtm
It does accept |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix documentation formatting
See here, for example.
Signed-off-by: Lala Sabathil <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It checks if the key exists and assigns value - if parameter was given to the edit method. If it doesn't exist, it will raise an Exception and not execute the else statement. I wrote it in the style everything is written, one could also use a normal if (var := sth.get(key)) is not None: ... |
Signed-off-by: David Hozic <[email protected]>
Signed-off-by: plun1331 <[email protected]>
Summary
This implements #2174.
Information
Added
default_reaction_emoji
parameter toGuild.create_forum_channel()
+ForumChannel.edit()
anddefault_reaction_emoji
attribute toForumChannel
.Example:
examples, ...).
Checklist
type: ignore
comments were used, a comment is also left explaining why.