Functions to verify hashtags #191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
These have been tested in hockeypuck for the last few months without known issues. |
twiss
approved these changes
Jun 21, 2024
|
I suspect the build checks in this PR were stale at time of merging, they pre-date the big merge commit in 4deafc1 in which several key functions have changed their signatures. I can't build main currently on my machine, I'll try to submit a remedial patch asap. |
|
Also note that this PR did not touch the v2 API (because it didn't exist when I wrote it!). It may therefore need to be duplicated. |
|
Ah right, my bad. Thanks! The v2 API doesn't duplicate the |
lubux
pushed a commit
that referenced
this pull request
Jun 24, 2024
Fixes the build issues with #191
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is sometimes desirable(*) to check the plausibility of a signature over a piece of data based on its HashTag, in situations where we are unable to fully verify the signature (e.g. due to a third-party signing key being unavailable). This implements the necessary functions by mirroring the corresponding signature verification functions.
It is difficult to implement these functions at the application level, due to lack of access to private methods such as userIdSignatureHash(), serializeWithoutHeaders() etc.
(It crossed my mind that it might be worth factorising out the common code from VerifySignature and VerifyHashTag, but that would require care handling the mutated hash and the version exception)
(* hockeypuck/hockeypuck#283)