Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update hashTag functions to use PrepareVerify #210

Merged
merged 1 commit into from
Jun 24, 2024
Merged

update hashTag functions to use PrepareVerify #210

merged 1 commit into from
Jun 24, 2024

Conversation

andrewgdotcom
Copy link
Contributor

No description provided.

@andrewgdotcom
Copy link
Contributor Author

andrewgdotcom commented Jun 21, 2024 •
edited
Loading

@twiss this should fix the breakage introduced by #191. Two of the failing tests appear to be because main is currently broken...?

@lubux lubux self-requested a review June 24, 2024 06:45
@lubux
Copy link
Contributor

lubux commented Jun 24, 2024 •
edited
Loading

Hi Andrew. Yeah it seems that #191 was created pre crypto-refresh merge, and did not consider the salt. Thanks for the fix, I tested it locally and it works.

@lubux lubux merged commit 3a86725 into ProtonMail:main Jun 24, 2024
6 of 8 checks passed
@twiss
Copy link
Member

twiss commented Jun 24, 2024

Thanks!

@andrewgdotcom andrewgdotcom deleted the upstream-fix branch June 30, 2024 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lubux lubux lubux approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andrewgdotcom @lubux @twiss