Correct meets_school_meal_categorical_eligibility for vectorized inputs #5318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaxGhenis
reviewed
Nov 8, 2024
policyengine_us/variables/gov/usda/school_meals/meets_school_meal_categorical_eligibility.py
Outdated
Show resolved
Hide resolved
|
Pushed the changes and confirmed they ran locally |
MaxGhenis
approved these changes
Nov 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5317
See the write-up in #5317 that explains how this bug functions. This PR changes how we evaluate whether or not someone is categorically eligible for free school meals, checking whether the total value they receive from eligible programs is greater than 0. This is supported for Booleans (since True is cast to 1) and supported by an added test.