Correct meets_school_meal_categorical_eligibility for vectorized inpu…

…ts (#5318)

* fix: Correct meets_school_meal_categorical_eligibility for vectorized inputs

* fix: Refactor formula for meets_school_meal_categorical_eligibility

changelog_entry.yaml

@@ -0,0 +1,6 @@
+- bump: patch
+  changes:
+    fixed:
+    - Corrected meets_school_meal_categorical_eligilibity to properly calculate eligibility for vectorized inputs.
+    added:
+    - Test for meets_school_meal_categorical_eligibility with vectorized inputs.

policyengine_us/tests/policy/baseline/gov/usda/school_meals/meets_school_meal_categorical_eligibility.yaml

@@ -81,3 +81,12 @@
       is_head_start_eligible: false
   output:
       meets_school_meal_categorical_eligibility: false
+
+- name: Vectorized operations
+  period: 2024
+  input:
+      snap: [1, 0, 0, 0, 0, 0, 0, 0]
+      fdpir: [0, 1, 1, 0, 0, 0, 0, 0]
+      is_homeless: [False, False, True, True, False, False, False, False]
+  output:
+      meets_school_meal_categorical_eligibility: [True, True, True, True, False, False, False, False]

policyengine_us/variables/gov/usda/school_meals/meets_school_meal_categorical_eligibility.py

@@ -8,8 +8,4 @@ class meets_school_meal_categorical_eligibility(Variable):
     documentation = "Whether this SPM unit is eligible for free school meal via participation in other programs"
     definition_period = YEAR
     reference = "https://www.law.cornell.edu/cfr/text/7/245.2"
-
-    def formula(spm_unit, period, parameters):
-        p = parameters(period).gov.usda.school_meals
-        programs = add(spm_unit, period, p.categorical_eligibility)
-        return np.any(programs)
+    adds = "gov.usda.school_meals.categorical_eligibility"