Setting SALT deduction to zero #171
Open
+14
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
How does this compare to the taxsim approach? |
i do not have that idea, today we have a call with dan, will share this with him that is this approach works for him. |
# Conflicts: # output/policyengine_taxsim_household_with_dependent_output.csv # output/policyengine_taxsim_household_with_dependent_single_parent_output.csv # output/policyengine_taxsim_joint_household_output.csv # output/policyengine_taxsim_single_household_output.csv
# Conflicts: # policyengine_taxsim/cli.py
|
Need to see whether we should also disable state level salt deductions to match TaxAct - my intuition is yes but confirming with Dan |
PavelMakarchuk
requested changes
Jan 7, 2025
| @@ -316,13 +320,17 @@ def export_household(taxsim_input, policyengine_situation, logs): | |||
|
|
|||
| def simulate(simulation, variable, year): | |||
| try: | |||
| if disable_salt_variable: | |||
| simulation.set_input(variable_name='salt_deduction', value=0.0) | |||
There was a problem hiding this comment.
Suggested change
| simulation.set_input(variable_name='salt_deduction', value=0.0) | |
| simulation.set_input(variable_name='state_and_local_sales_or_income_tax', value=0.0) |
| @@ -5,6 +5,7 @@ | |||
| from policyengine_us import Simulation | |||
| from policyengine_tests_generator.core.generator import PETestsYAMLGenerator | |||
|
|
|||
| disable_salt_variable = False | |||
There was a problem hiding this comment.
Suggested change
| disable_salt_variable = False | |
| set_state_and_local_sales_or_income_tax_to_zero = False |
There was a problem hiding this comment.
and other variables
| @@ -21,7 +21,8 @@ | |||
| help="Output file path", | |||
| ) | |||
| @click.option('--logs', is_flag=True, help='Generate PE YAML Tests Logs') | |||
| def main(input_file, output, logs): | |||
| @click.option('--disable-salt', is_flag=True, default=False, help='Set Salt Deduction to 0.0') | |||
There was a problem hiding this comment.
Suggested change
| @click.option('--disable-salt', is_flag=True, default=False, help='Set Salt Deduction to 0.0') | |
| @click.option('--disable-salt', is_flag=True, default=False, help='Set the State and Local Income Tax to 0.0') |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
set
salt_deduction0.0 from cli argumentpython policyengine_taxsim\cli.py input.csv --disable-saltFixes #160