Refactor user_profile to use blueprints #2067
Conversation
mikesmit
force-pushed
the
1989_user_profile_to_blueprint
branch
2 times, most recently
from
c3cdf8e to
4ce2135
Compare
MaxGhenis
changed the title
|
Test is failing on build. I don't believe it failed on desktop. Investigating why... |
|
Confirmed make debug-test passes locally. |
mikesmit
force-pushed
the
1989_user_profile_to_blueprint
branch
from
4ce2135 to
7fcf974
Compare
mikesmit
force-pushed
the
1989_user_profile_to_blueprint
branch
from
7fcf974 to
8fd9c30
Compare
mikesmit
force-pushed
the
1989_user_profile_to_blueprint
branch
from
8fd9c30 to
5cae080
Compare
|
The original issue was that MySQL does not like " around column names but SQLite is happy with them (thus the failure on deploy test instead of desktop test) WRT the issue link: yeah that was wrong. I fixed it in the commit, but that didn't auto-update the PR. Thank you for fixing. Now the test are failing on policy tests. Possibly related to MySQL as well, but less obvious. |
| from werkzeug.exceptions import BadRequest, NotFound | ||
|
|
||
| user_profile_bp = Blueprint("user_profile", __name__) | ||
| user_service = UserService() |
There was a problem hiding this comment.
suggestion, non-blocking: Rename this to UserProfileService (or something similar)
We also have a user_policy table that should have its own service in the future, and I wouldn't be surprised if we stored more user-related data in the future. I think it might be advantageous to make the service name more descriptive.
fixes #1989, fixes #2059
This migrates the code for the user profile resource to use blueprints.
It also fixes an issue where the PUT operation allowed malicious injection attacks on our database.