Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate user_profile endpoints to new API structure #1989

Open
anth-volk opened this issue Nov 19, 2024 · 6 comments · May be fixed by #2067
Open

Migrate user_profile endpoints to new API structure #1989

anth-volk opened this issue Nov 19, 2024 · 6 comments · May be fixed by #2067
Assignees
@mikesmit

Comments

@anth-volk
Copy link
Collaborator

No description provided.

@mikesmit mikesmit self-assigned this Dec 16, 2024
@mikesmit
Copy link
Collaborator

picking this up and basing the style on #2038 and the modifications Anthony has been making.

This was referenced Dec 17, 2024
Open
Open
@mikesmit
Copy link
Collaborator

I have done a version of this here: https://github.com/PolicyEngine/policyengine-api/tree/1989_user_profile_to_blueprint but I need @anth-volk 's changes from his PR to actually finalize it (specifically the exception response binding).

@mikesmit
Copy link
Collaborator

picking this back up now to rebase on anthony's change. This should fix a major security issue.

@mikesmit
Copy link
Collaborator

ok rebase fixed the failing unit tests (for error handling). In the interests of plugging the immediate security issue I'm submitting that PR now (without breaking out service tests)

@mikesmit
Copy link
Collaborator

opened pull request: #2067

@mikesmit
Copy link
Collaborator

oops forgot to add the versioning stuff. doing that now..

mikesmit pushed a commit that referenced this issue Dec 23, 2024
Refactor user_profile to use blueprints
7fcf974 
fixes #1989, fixes #2059

This migrates the code for the user profile resource to use blueprints.

It also fixes an issue where the PUT operation allowed malicious
injection attacks on our database.
@anth-volk anth-volk linked a pull request Dec 23, 2024 that will close this issue
Open
mikesmit pushed a commit that referenced this issue Dec 23, 2024
Refactor user_profile to use blueprints
8fd9c30 
fixes #1989, fixes #2059

This migrates the code for the user profile resource to use blueprints.

It also fixes an issue where the PUT operation allowed malicious
injection attacks on our database.
mikesmit pushed a commit that referenced this issue Dec 23, 2024
Refactor user_profile to use blueprints
5cae080 
fixes #1989, fixes #2059

This migrates the code for the user profile resource to use blueprints.

It also fixes an issue where the PUT operation allowed malicious
injection attacks on our database.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mikesmit mikesmit

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Refactor user_profile to use blueprints PolicyEngine/policyengine-api
2 participants
@mikesmit @anth-volk