ClickHouse: Put numeric-string mapping behind feature flag #2305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iskakaushik
approved these changes
Nov 30, 2024
serprex
approved these changes
Dec 2, 2024
serprex
reviewed
Dec 2, 2024
serprex
reviewed
Dec 2, 2024
serprex
reviewed
Dec 2, 2024
Amogh-Bharadwaj
force-pushed
the
numeric-string-ff
branch
from
e632431 to
4e40bb2
Compare
serprex
force-pushed
the
numeric-string-ff
branch
from
a93243c to
b75a8f2
Compare
serprex
reviewed
Dec 2, 2024
serprex
force-pushed
the
numeric-string-ff
branch
2 times, most recently
from
5ac2e4f to
b92c6c5
Compare
… ch string becomes binary goop
serprex
force-pushed
the
numeric-string-ff
branch
from
e004787 to
092d4da
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Unbounded numerics in Postgres databases statistically are unlikely to have values with dimensions larger than 76,38.
Currently by default unbounded
numericin postgres is mapped to String in ClickHouse - an unideal mapping from data nativity point of view and only useful for the scarce cases mentioned aboveWhat
This PR puts this mapping choice behind a dynamic setting flag whose default is false - thereby restoring the default mapping to numeric to Decimal in all cases
Adapted the E2E test for this