compartmentalize code a bit

PeerDB-io · Dec 2, 2024 · a93243c · a93243c
1 parent 4e40bb2
commit a93243c
Showing 1 changed file with 5 additions and 7 deletions.
diff --git a/flow/connectors/clickhouse/normalize.go b/flow/connectors/clickhouse/normalize.go
@@ -82,7 +82,6 @@ func getColName(overrides map[string]string, name string) string {
 }
 
 func getClickhouseTypeForNumericColumn(ctx context.Context, column *protos.FieldDescription, env map[string]string) (string, error) {
-	rawPrecision, _ := datatypes.ParseNumericTypmod(column.TypeModifier)
 	if column.TypeModifier == -1 {
 		numericAsStringEnabled, err := peerdbenv.PeerDBEnableClickHouseNumericAsString(ctx, env)
 		if err != nil {
@@ -91,12 +90,11 @@ func getClickhouseTypeForNumericColumn(ctx context.Context, column *protos.Field
 		if numericAsStringEnabled {
 			return "String", nil
 		}
-		precision, scale := datatypes.GetNumericTypeForWarehouse(column.TypeModifier, datatypes.ClickHouseNumericCompatibility{})
-		return fmt.Sprintf("Decimal(%d, %d)", precision, scale), nil
-	}
-
-	if rawPrecision > datatypes.PeerDBClickHouseMaxPrecision {
-		return "String", nil
+	} else {
+		rawPrecision, _ := datatypes.ParseNumericTypmod(column.TypeModifier)
+		if rawPrecision > datatypes.PeerDBClickHouseMaxPrecision {
+			return "String", nil
+		}
 	}
 	precision, scale := datatypes.GetNumericTypeForWarehouse(column.TypeModifier, datatypes.ClickHouseNumericCompatibility{})
 	return fmt.Sprintf("Decimal(%d, %d)", precision, scale), nil