Update inverse app projection to work with ZK proofs #327
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SebastienGllmt
force-pushed
the
app-projected-zk
branch
from
d8443be to
f4e92e6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the previous version of the inverse projection contract, there was no way to add custom validation logic for the mint. However, in the future, it's possible we have inverse projections where we can actually verify with a ZK proof that the mint is valid.
To make sure these two cases work with the same interface, I made the following changes:
_verificationDataparameter to themintfunction (which would contain the ZK verification data)validateMintfunction so you can easily inherent from our base contract to add your own ZK verificationUnrelated to this, I also added a
currentNonceto the interface in case it's useful for frontends