Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Another wave of PRC3 feedback #7

Merged
merged 1 commit into from
Mar 24, 2024
Merged

Another wave of PRC3 feedback #7

merged 1 commit into from
Mar 24, 2024

Conversation

SebastienGllmt
Copy link
Contributor

@SebastienGllmt SebastienGllmt commented Mar 23, 2024

This PR makes more changes to PRC3 based on my discussion with @matejos

  1. (new feature) The IInverseAppProjectedNft optionally takes a new parameter _verificationData to its mint function for cases where the mint validity can be verified (ex: zk proof). See Update inverse app projection to work with ZK proofs paima-engine#327
  2. (new feature) The IInverseAppProjectedNft now exposes a currentNonce getter for cases frontends want to know the nonce for the user's address
  3. (refactor) Tracking invalid mints section moved because it was in the wrong place
  4. (security fix) All NFTs now need to have a validity trait type to allow users to safely place collection offers
  5. (security fix) the state transition to process the inverse projection should never failshould never fail for any reason other than signature mismatch. If the user's signature doesn't match, we shouldn't increment userTokenId otherwise you could grief a user by minting many failed txs on their behalf

@SebastienGllmt SebastienGllmt self-assigned this Mar 23, 2024
@SebastienGllmt SebastienGllmt merged commit 71047d1 into main Mar 24, 2024
@SebastienGllmt SebastienGllmt deleted the more-prc3-feedback branch March 24, 2024 05:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant