Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add externally connected wallets into Paima #250

Merged
merged 14 commits into from
Oct 31, 2023
Merged

Conversation

SebastienGllmt
Copy link
Contributor

This PR reworks the wallet connection mechanism to allow including wallets that were initialized externally to be use by Paima. You can find the docs on this here

Bug fixes

  • Fix start.sh docker script being broken
  • Fix message signing for Nami wallet
  • Fix wait for emulated blocks throwing instead of waiting
  • Fix named connection type for Etheruem potentially missing a wallet if that wallet implements multiple injection standards
  • Fix some wallets aggressively adding themselves as the default even if a user has never installed it (ex: Brave's built-in crypto wallet)

Features

  • Allow multiple providers to be connected at once. Useful if you want a browser wallet connected to Paima at the same time as a session key
  • Add a way to specify "default" connector to be used unless explicitly told not to (useful to make the session key the default)
  • Add support for any Ethers Signer (@ethersproject/abstract-signer) based wallets
  • Add allInjectedWallets to get all the injected wallets of every cryptocurrency Paima supports at once

Breaking changes

  • getAddress on connectors now returns a struct to specify the address type (instead of just the address string)
  • userWalletLogin parameters changed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant