-
Notifications
You must be signed in to change notification settings - Fork 13.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gnss: update supported baud rates #23415
Merged
julianoes
merged 2 commits into
PX4:main
from
flyingthingsintothings:pr-fix-septentrio-baud-rates
Aug 6, 2024
Merged
gnss: update supported baud rates #23415
julianoes
merged 2 commits into
PX4:main
from
flyingthingsintothings:pr-fix-septentrio-baud-rates
Aug 6, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julianoes
reviewed
Jul 17, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice thanks. You need to check on Linux/POSIX. Some of the defines don't seem to be available. Maybe just use an #ifdef
to check?
The Septentrio GNSS driver requires certain baud rates to test all the supported baud rates of the receiver. Without these changes, certain "non-standard" ones would print an error to the MAVLink console when the driver was started through the console.
julianoes
force-pushed
the
pr-fix-septentrio-baud-rates
branch
from
July 28, 2024 20:15
cfb35b0
to
b8c2f10
Compare
julianoes
added a commit
to julianoes/PX4-Autopilot
that referenced
this pull request
Aug 7, 2024
* gnss: update supported baud rates The Septentrio GNSS driver requires certain baud rates to test all the supported baud rates of the receiver. Without these changes, certain "non-standard" ones would print an error to the MAVLink console when the driver was started through the console. * platforms: add missing baudrate defines --------- Co-authored-by: Thomas Frans <[email protected]> Co-authored-by: Julian Oes <[email protected]>
julianoes
added a commit
that referenced
this pull request
Aug 8, 2024
* gnss: update supported baud rates The Septentrio GNSS driver requires certain baud rates to test all the supported baud rates of the receiver. Without these changes, certain "non-standard" ones would print an error to the MAVLink console when the driver was started through the console. * platforms: add missing baudrate defines --------- Co-authored-by: Thomas Frans <[email protected]> Co-authored-by: Julian Oes <[email protected]>
julianoes
added a commit
that referenced
this pull request
Aug 8, 2024
* gnss: update supported baud rates The Septentrio GNSS driver requires certain baud rates to test all the supported baud rates of the receiver. Without these changes, certain "non-standard" ones would print an error to the MAVLink console when the driver was started through the console. * platforms: add missing baudrate defines --------- Co-authored-by: Thomas Frans <[email protected]> Co-authored-by: Julian Oes <[email protected]>
vertiq-jordan
pushed a commit
to iq-motion-control/PX4-Autopilot
that referenced
this pull request
Aug 21, 2024
* gnss: update supported baud rates The Septentrio GNSS driver requires certain baud rates to test all the supported baud rates of the receiver. Without these changes, certain "non-standard" ones would print an error to the MAVLink console when the driver was started through the console. * platforms: add missing baudrate defines --------- Co-authored-by: Thomas Frans <[email protected]> Co-authored-by: Julian Oes <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Septentrio GNSS driver requires certain baud rates to test all the supported baud rates of the receiver. Without these changes, certain "non-standard" ones would print an error to the MAVLink console when the driver was started through the console.
Solved Problem
This is an alternative to #23374 with the change suggested by @julianoes.
Fixes #23374
Solution
SerialImpl.cpp
Changelog Entry
For release notes:
Alternatives
See #23374 for alternatives.
Test coverage
Context
/