Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gnss: update supported baud rates #23415

Merged

Conversation

flyingthingsintothings
Copy link
Contributor

@flyingthingsintothings flyingthingsintothings commented Jul 16, 2024

The Septentrio GNSS driver requires certain baud rates to test all the supported baud rates of the receiver. Without these changes, certain "non-standard" ones would print an error to the MAVLink console when the driver was started through the console.

Solved Problem

This is an alternative to #23374 with the change suggested by @julianoes.

Fixes #23374

Solution

  • Add the required baud rates to SerialImpl.cpp
  • Test on a Holybro Pixhawk 6C mini to make sure all of them work

Changelog Entry

For release notes:

Bugfix Add new baud rates required by Septentrio driver

Alternatives

See #23374 for alternatives.

Test coverage

  • Manual testing of all the newly added baud rates with the Septentrio driver, making sure no more warnings are printed and the driver successfully discovers the receiver.

Context

/

Copy link
Contributor

@julianoes julianoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice thanks. You need to check on Linux/POSIX. Some of the defines don't seem to be available. Maybe just use an #ifdef to check?

ThomasFrans and others added 2 commits July 29, 2024 08:09
The Septentrio GNSS driver requires certain baud rates to test all the
supported baud rates of the receiver. Without these changes, certain
"non-standard" ones would print an error to the MAVLink console when the
driver was started through the console.
@julianoes julianoes force-pushed the pr-fix-septentrio-baud-rates branch from cfb35b0 to b8c2f10 Compare July 28, 2024 20:15
@julianoes julianoes merged commit 3157a4e into PX4:main Aug 6, 2024
88 of 92 checks passed
julianoes added a commit to julianoes/PX4-Autopilot that referenced this pull request Aug 7, 2024
* gnss: update supported baud rates

The Septentrio GNSS driver requires certain baud rates to test all the
supported baud rates of the receiver. Without these changes, certain
"non-standard" ones would print an error to the MAVLink console when the
driver was started through the console.

* platforms: add missing baudrate defines

---------

Co-authored-by: Thomas Frans <[email protected]>
Co-authored-by: Julian Oes <[email protected]>
julianoes added a commit that referenced this pull request Aug 8, 2024
* gnss: update supported baud rates

The Septentrio GNSS driver requires certain baud rates to test all the
supported baud rates of the receiver. Without these changes, certain
"non-standard" ones would print an error to the MAVLink console when the
driver was started through the console.

* platforms: add missing baudrate defines

---------

Co-authored-by: Thomas Frans <[email protected]>
Co-authored-by: Julian Oes <[email protected]>
julianoes added a commit that referenced this pull request Aug 8, 2024
* gnss: update supported baud rates

The Septentrio GNSS driver requires certain baud rates to test all the
supported baud rates of the receiver. Without these changes, certain
"non-standard" ones would print an error to the MAVLink console when the
driver was started through the console.

* platforms: add missing baudrate defines

---------

Co-authored-by: Thomas Frans <[email protected]>
Co-authored-by: Julian Oes <[email protected]>
vertiq-jordan pushed a commit to iq-motion-control/PX4-Autopilot that referenced this pull request Aug 21, 2024
* gnss: update supported baud rates

The Septentrio GNSS driver requires certain baud rates to test all the
supported baud rates of the receiver. Without these changes, certain
"non-standard" ones would print an error to the MAVLink console when the
driver was started through the console.

* platforms: add missing baudrate defines

---------

Co-authored-by: Thomas Frans <[email protected]>
Co-authored-by: Julian Oes <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants