Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gnss: limit to supported baudrates #23374

Closed
wants to merge 1 commit into from
Closed

gnss: limit to supported baudrates #23374

wants to merge 1 commit into from

Conversation

julianoes
Copy link
Contributor

Without this change, the console is flooded with warnings like this:

WARN  [SerialImpl] Using non-standard baudrate: 500000

FYI @flyingthingsintothings

Without this change, the console is flooded with warnings like this:
WARN  [SerialImpl] Using non-standard baudrate: 500000
@julianoes julianoes requested a review from dagar July 8, 2024 22:37
@flyingthingsintothings
Copy link
Contributor

flyingthingsintothings commented Jul 8, 2024

I thought about this when I wrote the driver. The problem is that these non-standard baud rates are supported on the receivers, so if the user set them before, the driver can't configure the receiver because it won't detect these non-standard baud rates. A better option would be to move all the non-standard ones at the end of the array to not print warnings if the receiver is using a standard one. Another option would be to document the non-standard baud rates in the dev docs instead of printing warnings.

@julianoes
Copy link
Contributor Author

Alternatively, you could add the baudrates to SerialImpl and then test it, to make sure they work.

@flyingthingsintothings
Copy link
Contributor

Sorry for the late reply. I was away for a week.

I'll try to add the baud rates and test with that. That seems like the cleanest, correct solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants