Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add T2* as outlook #617

Merged
merged 2 commits into from
Jan 20, 2025
Merged

Add T2* as outlook #617

merged 2 commits into from
Jan 20, 2025

Conversation

ckolbPTB
Copy link
Collaborator

I had a look at the QMRI Challenge ISMRM 2024 T2* notebook and the results are still the same as what we had before. The only problem was the vmax setting in the final plot was too high. So everything is still working as expected.

My suggestion would be to add the T2* part as a "do-it-yourself" part at the end - would be very useful for training courses and practical sessions.

@ckolbPTB ckolbPTB added the pre-commit.ci autofix run autofix in this PR label Jan 20, 2025
@pre-commit-ci pre-commit-ci bot removed the pre-commit.ci autofix run autofix in this PR label Jan 20, 2025
Copy link
Contributor

github-actions bot commented Jan 20, 2025

Coverage

Coverage Report
FileStmtsMissCoverMissing
src/mrpro/algorithms/csm
   inati.py24196%44
   walsh.py16194%52
src/mrpro/algorithms/dcf
   dcf_voronoi.py53492%15, 55–56, 89
src/mrpro/algorithms/optimizers
   adam.py20195%101
src/mrpro/algorithms/reconstruction
   DirectReconstruction.py281643%59–79, 93
   IterativeSENSEReconstruction.py13192%79
   Reconstruction.py502256%42, 54–56, 80–87, 108–117
   RegularizedIterativeSENSEReconstruction.py411759%97–101, 115–140
src/mrpro/data
   AcqInfo.py128398%26, 169, 207
   CsmData.py29390%15, 84–86
   DcfData.py45882%18, 66, 78–83
   IData.py67987%120, 126, 130, 160–168
   IHeader.py75791%75, 109, 127–131
   KData.py2142588%111–112, 127, 134, 144, 152, 206–207, 245, 250–251, 270–281, 440, 442, 507, 522, 559, 590, 599
   KHeader.py1531789%25, 119–123, 150, 199, 210, 217–218, 221, 228, 260–271
   KNoise.py311552%39–52, 56–61
   KTrajectory.py811285%112–117, 120–122, 207–211
   MoveDataMixin.py1401887%28, 126, 142, 156–158, 220, 336–338, 351, 430, 450–451, 453, 468–469, 471
   QData.py39782%42, 65–73
   Rotation.py6743595%100, 198, 335, 433, 477, 495, 582, 584, 593, 627, 629, 692, 769, 774, 777, 792, 809, 814, 890, 1078, 1083, 1086, 1110, 1114, 1242, 1244, 1252–1253, 1317, 1399, 1692, 1844, 1879, 1883, 1994
   SpatialDimension.py2322191%34, 104, 141, 148, 154, 274–276, 289–291, 325, 343, 356, 369, 382, 395, 404–405, 420, 429
   acq_filters.py12192%47
src/mrpro/data/traj_calculators
   KTrajectoryCalculator.py25292%23, 45
   KTrajectoryIsmrmrd.py13285%41, 50
   KTrajectoryPulseq.py23196%55
src/mrpro/operators
   CartesianSamplingOp.py89397%118, 157, 280
   ConstraintsOp.py60297%46, 48
   EndomorphOperator.py65297%228, 234
   FiniteDifferenceOp.py27293%40, 105
   FourierOp.py158398%274, 392, 397
   Functional.py71593%20–22, 117, 119
   GridSamplingOp.py136993%72–73, 82–83, 90–91, 94, 96, 98
   LinearOperator.py1681094%55, 114, 224, 254, 295, 304, 312, 321, 329, 364
   LinearOperatorMatrix.py1581690%82, 119, 152, 161, 166, 175–178, 191–194, 203, 215, 304, 331, 359
   MultiIdentityOp.py13285%43, 48
   Operator.py78297%31, 87
   ProximableFunctionalSeparableSum.py39392%50, 103, 110
   SliceProjectionOp.py173895%44, 61, 63, 69, 206, 227, 260, 300
   WaveletOp.py119596%151, 169, 204, 209, 232
   ZeroPadOp.py16194%30
src/mrpro/utils
   filters.py62297%44, 49
   reshape.py60198%192
   slice_profiles.py46687%20, 36, 113–116, 149
   sliding_window.py34197%34
   split_idx.py10280%43, 47
   summarize_tensorvalues.py11918%20–29
   typing.py211148%8–23
   zero_pad_or_crop.py31681%26, 30, 55, 58, 61, 64
TOTAL489336093% 

Tests Skipped Failures Errors Time
2291 0 💤 0 ❌ 0 🔥 1m 9s ⏱️

@fzimmermann89
Copy link
Member

Good solution!

Copy link
Contributor

📚 Documentation

📁 Download as zip
🔍 View online

@fzimmermann89 fzimmermann89 merged commit 562c1cb into improvedoc Jan 20, 2025
20 checks passed
@fzimmermann89 fzimmermann89 deleted the improvedoc-challenge branch January 20, 2025 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants