specify prefix for filter plugins #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The missing prefix has hazardous consequences due to a series of unfortunate events involving the filters and the laser_filters package..
v4hn
force-pushed
the
pr-hydro-fix-broken-filters-plugin
branch
from
03f2a9f to
d75526a
Compare
v4hn
added a commit
to v4hn/pr2_navigation
that referenced
this pull request
Apr 7, 2017
In our setup (an off-the-shelf PR2 with respect to these parts) the previous parameters were too tight: In many situations, especially when an obstacle split the ground-part of a single laser-scan into two segments, one of these segments is not picked up by the line-RANSAC with the old parameters. Thus it ends up as an obstacle obstructing the local costmap of the navigation. With indigo, nobody else noticed this up to now because of a broken filter-chain before that(see PR2#27).
v4hn
added a commit
to TAMS-Group/pr2_navigation
that referenced
this pull request
Apr 10, 2017
In our setup (an off-the-shelf PR2 with respect to these parts) the previous parameters were too tight: In many situations, especially when an obstacle split the ground-part of a single laser-scan into two segments, one of these segments is not picked up by the line-RANSAC with the old parameters. Thus it ends up as an obstacle obstructing the local costmap of the navigation. With indigo, nobody else noticed this up to now because of a broken filter-chain before that(see PR2#27).
|
@k-okada Yes, I think we also need to update the file. |
|
@furushchev oh, i mean do you approve this change? (but if so, i think our pr2 fail to run laser filters, is it correct?) |
|
I have talked to @furushchev online and confirmed this change is required and our pr2 is running without this future until now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The missing prefix has hazardous consequences due
to a series of unfortunate events involving the filters and the
laser_filters package..
See ros-perception/laser_filters#50 for more details.
Fixes #26