Fixed issue #2, missing attribute "version" on root element.

OxalisCommunity · Feb 9, 2016 · b66d47e · b66d47e
1 parent cb02084
commit b66d47e
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 2 deletions.
diff --git a/peppol-evidence/src/main/java/no/difi/vefa/peppol/evidence/rem/RemEvidenceBuilder.java b/peppol-evidence/src/main/java/no/difi/vefa/peppol/evidence/rem/RemEvidenceBuilder.java
@@ -34,7 +34,7 @@
 public class RemEvidenceBuilder {
 
     private final EvidenceTypeInstance evidenceTypeInstance;
-    private String version;
+    private final String version = "1";
     private EventCode eventCode;
     private EventReason eventReason;
     private String evidenceIdentifier = UUID.randomUUID().toString();

diff --git a/peppol-evidence/src/test/java/no/difi/vefa/peppol/evidence/rem/RemEvidenceBuilderTest.java b/peppol-evidence/src/test/java/no/difi/vefa/peppol/evidence/rem/RemEvidenceBuilderTest.java
@@ -67,6 +67,13 @@ public void createSampleRemEvidence() throws Exception {
 
         // Grabs the REMEvidenceType instance in order to make some assertions.
         REMEvidenceType remEvidenceInstance = signedRemEvidence.getRemEvidenceType();
+
+        // Issue #2
+        assertNotNull(remEvidenceInstance.getVersion(), "The version attribute was not set!");
+        assertEquals(remEvidenceInstance.getVersion(), "1");
+        // ------------- Issue #2 --------------
+
+
         assertEquals(remEvidenceInstance.getEventCode(), EventCode.ACCEPTANCE.getValue().toString());
 
         // Transforms the rem evidence instance into an XML representation suitable for some checks.

diff --git a/peppol-evidence/src/test/resources/sample-signed-formatted-rem.xml b/peppol-evidence/src/test/resources/sample-signed-formatted-rem.xml
@@ -31,7 +31,7 @@
         <Extension>
             <ns4:Any>
                 <ns7:PeppolRemExtension>
-                    <ns7:TransmissionProtocol>no.difi.vefa.peppol.common.model.TransportProfile@bf16137f</ns7:TransmissionProtocol>
+                    <ns7:TransmissionProtocol>AS2</ns7:TransmissionProtocol>
                     <ns7:TransmissionRole>C3</ns7:TransmissionRole>
                     <ns7:OriginalReceipt>
                         TWVzc2FnZS1JRDogPDQwNzY5NzM1OS4zLjE0NDg5Nzk0Mzg5NjkuSmF2YU1haWwuc3RlaW5hckBtYWNzdGVpbmFyMy5sb2NhbD4NCk1JTUUtVmVyc2lvbjogMS4wDQpDb250ZW50LVR5cGU6IG11bHRpcGFydC9zaWduZWQ7IHByb3RvY29sPSJhcHBsaWNhdGlvbi9wa2NzNy1zaWduYXR1cmUiOyBtaWNhbGc9c2hhLTE7IA0KCWJvdW5kYXJ5PSItLS0tPV9QYXJ0XzJfMzMxNDE4NTAzLjE0NDg5Nzk0Mzg5NjMiDQoNCi0tLS0tLT1fUGFydF8yXzMzMTQxODUwMy4xNDQ4OTc5NDM4OTYzDQpDb250ZW50LVR5cGU6IG11bHRpcGFydC9yZXBvcnQ7IHJlcG9ydC10eXBlPWRpc3Bvc2l0aW9uLW5vdGlmaWNhdGlvbjsgDQoJYm91bmRhcnk9Ii0tLS09X1BhcnRfMF8zMjk2NDU2MTkuMTQ0ODk3OTQzODMyOSINCg0KLS0tLS0tPV9QYXJ0XzBfMzI5NjQ1NjE5LjE0NDg5Nzk0MzgzMjkNCkNvbnRlbnQtVHlwZTogdGV4dC9wbGFpbg0KQ29udGVudC1UcmFuc2Zlci1FbmNvZGluZzogN2JpdA0KDQpUaGUgZm9sbG93aW5nIGhlYWRlcnMgd2VyZSByZWNlaXZlZDoNCg0KVGhlIG1lc3NhZ2Ugc2VudCB0byBBUzIgU3lzdGVtIGlkIEFQXzAwMDA0IG9uIHRpLCAwMSBkZXMgMjAxNSAxNToxNzoxOCArMDEwMCB3aXRoIHN1YmplY3QgTUROIHdpdGggUGF5bG9hZERpZ2VzdCBoYXMgYmVlbiByZWNlaXZlZC4NCkl0IGhhcyBiZWVuIHByb2Nlc3NlZCBzdWNjZXNzZnVsbHkuDQoNCi0tLS0tLT1fUGFydF8wXzMyOTY0NTYxOS4xNDQ4OTc5NDM4MzI5DQpDb250ZW50LVR5cGU6IG1lc3NhZ2UvZGlzcG9zaXRpb24tbm90aWZpY2F0aW9uDQpDb250ZW50LVRyYW5zZmVyLUVuY29kaW5nOiA3Yml0DQoNClJlcG9ydGluZy1VQTogT3hhbGlzDQpEaXNwb3NpdGlvbjogYXV0b21hdGljLWFjdGlvbi9NRE4tc2VudC1hdXRvbWF0aWNhbGx5OyBwcm9jZXNzZWQNCk9yaWdpbmFsLVJlY2lwaWVudDogcmZjODIyOyBBUF8wMDAwNA0KRmluYWwtUmVjaXBpZW50OiByZmM4MjI7IEFQXzAwMDA0DQpPcmlnaW5hbC1NZXNzYWdlLUlEOiANClgtUEVQUE9MLVRpbWVTdGFtcDogMjAxNS0xMi0wMVQxNToxNzoxOC4zMTYrMDE6MDANClgtT3JpZ2luYWwtTWVzc2FnZS1kaWdlc3Q6IGZUaTF6U1dpdXZoYTA3dGJreEU0UG1jYWloUXVzd0t6Sk5TbCs2aDBqR2s9DQpYLU9yaWdpbmFsLU1lc3NhZ2UtYWxnOiBTSEEtMjU2DQpSZWNlaXZlZC1Db250ZW50LU1JQzogZWVXTmtPVHg3eUpZcjJFVzhDUjg1STdRSlFZPSwgc2hhMQ0KDQoNCi0tLS0tLT1fUGFydF8wXzMyOTY0NTYxOS4xNDQ4OTc5NDM4MzI5LS0NCg0KLS0tLS0tPV9QYXJ0XzJfMzMxNDE4NTAzLjE0NDg5Nzk0Mzg5NjMNCkNvbnRlbnQtVHlwZTogYXBwbGljYXRpb24vcGtjczctc2lnbmF0dXJlOyBuYW1lPXNtaW1lLnA3czsgc21pbWUtdHlwZT1zaWduZWQtZGF0YQ0KQ29udGVudC1UcmFuc2Zlci1FbmNvZGluZzogYmFzZTY0DQpDb250ZW50LURpc3Bvc2l0aW9uOiBhdHRhY2htZW50OyBmaWxlbmFtZT0ic21pbWUucDdzIg0KQ29udGVudC1EZXNjcmlwdGlvbjogUy9NSU1FIENyeXB0b2dyYXBoaWMgU2lnbmF0dXJlDQoNCk1JQUdDU3FHU0liM0RRRUhBcUNBTUlBQ0FRRXhDekFKQmdVckRnTUNHZ1VBTUlBR0NTcUdTSWIzRFFFSEFRQUFvSUF3Z2dSNU1JSUQNCllhQURBZ0VDQWhBR2d0WjBNRDB4Y2ZNNTZ3cFJyQWxZTUEwR0NTcUdTSWIzRFFFQkN3VUFNSDB4Q3pBSkJnTlZCQVlUQWtSTE1TY3cNCkpRWURWUVFLRXg1T1FWUkpUMDVCVENCSlZDQkJUa1FnVkVWTVJVTlBUU0JCUjBWT1Exa3hIekFkQmdOVkJBc1RGa1pQVWlCVVJWTlUNCklGQlZVbEJQVTBWVElFOU9URmt4SkRBaUJnTlZCQU1URzFCRlVGQlBUQ0JCUTBORlUxTWdVRTlKVGxRZ1ZFVlRWQ0JEUVRBZUZ3MHgNCk5URXdNRFl3TURBd01EQmFGdzB4TnpFd01EVXlNelU1TlRsYU1Fc3hDekFKQmdOVkJBWVRBazVQTVNNd0lRWURWUVFLREJwRVNVWkoNCklDaFBlR0ZzYVhNZ2NtVnVaWGRoYkNCMFpYTjBLVEVYTUJVR0ExVUVBd3dPUVZCUVh6RXdNREF3TURBeE16VXdnZ0VpTUEwR0NTcUcNClNJYjNEUUVCQVFVQUE0SUJEd0F3Z2dFS0FvSUJBUURRMVRuSmZpTGhuQW5QQWlKV3V4WGc4a21OM3lQWnUrd1gyNG9XaEJXbWpIL20NCmFsdXoydFVCTWJRbmJxQ1dDbW9SZFV2cEl1dkZudFpCVFdOQ3BFdldJaWpSS1dha05pME1qenFyUHBYaGlNSnhxb3J2UjFXc3Z1SmoNCjJNRUlERDBXK1A4ZldXdkdVVyt6U2RIWU5NYkZodkFDUythVTZuWE9GUTVaRnZRUzFuVGRIdHJBbU1DR0owZmplWU9jc0xhNklZUkgNCnlWNDIxVnowQ0IrYlBWeUx3WjFLWXdLL0tKd3oyZTc5elB3eGkzNVk0d01KT1F4ZDVUMFZwRlZ1b282NjFiR2VUdzVLeEFmbnBnL0wNCkJuRzhLQjV0ZVFyR2hpUTVKVW00cmgzQjd3TWd5S1JjYlgvNFdkcW0zSGd3L2dTanhncWljNWtRT1c5bVBLUkJsTGZ0QWdNQkFBR2oNCmdnRWxNSUlCSVRBSkJnTlZIUk1FQWpBQU1Bc0dBMVVkRHdRRUF3SUR1REIyQmdOVkhSOEViekJ0TUd1Z2FhQm5obVZvZEhSd09pOHYNCmNHbHNiM1J2Ym5OcGRHVmpjbXd1ZG1WeWFYTnBaMjR1WTI5dEwwUnBaMmwwWVd4cGMyVnlhVzVuYzNOMGVYSmxiSE5sYmxCcGJHOTANClQzQmxibEJGVUZCUFRFRkRRMFZUVTFCUFNVNVVRMEV2VEdGMFpYTjBRMUpNTG1OeWJEQWZCZ05WSFNNRUdEQVdnQlQzbG9zWlRLN2kNClZpRUF2b2I5ZWtlc25jb0ZkVEFkQmdOVkhRNEVGZ1FVVmdGRld2UnpiYkcyMk5rRjdhWVpnZzVrcXhFd09nWUlLd1lCQlFVSEFRRUUNCkxqQXNNQ29HQ0NzR0FRVUZCekFCaGg1b2RIUndPaTh2Y0dsc2IzUXRiMk56Y0M1MlpYSnBjMmxuYmk1amIyMHdFd1lEVlIwbEJBd3cNCkNnWUlLd1lCQlFVSEF3SXdEUVlKS29aSWh2Y05BUUVMQlFBRGdnRUJBQWVLOW9tWkZBNmRJUlNOc1BBSmtPV29QY2dIN3gvcmVBcUMNCkY3QXBQdXpLaWxGNzdlY2JEbU5GckhSRmozWG5aVTBDTUZjOFBiWHhadHpwREhGTVVFL2NxcUpwVE84aDFPT1E1NFpIL0lhcThqb0INCmcwMzNaY3pMVE5OYWtaOFBKU0ZRUTdHejJldStJNkZ2ZjhhSE1GK1N4RnZtSFp0OFNLVDkzZGhZYXpwc0pHaUMrN0VGODE5QzViL0UNClpKRnNQcUx5VitEejB3L09sVnZGUnlFbFN6U1hFTVFmdEVqYmFvc2liVEQxMFFsTlFEY3d5MUJueWtHdEN1WlRDdmtQQUpwUmJLcUMNCjMvZnlYZXFXLzBML1lCNEc2SkpHajJaSnd2N1NXWm9UT2Zac20xL2xNUXJyMUtuRHFyLytSQzhGQ3FWVGEyT21FdGxoVmNlZ2lEUkENCmc0QUFBREdDQWtRd2dnSkFBZ0VCTUlHUk1IMHhDekFKQmdOVkJBWVRBa1JMTVNjd0pRWURWUVFLRXg1T1FWUkpUMDVCVENCSlZDQkINClRrUWdWRVZNUlVOUFRTQkJSMFZPUTFreEh6QWRCZ05WQkFzVEZrWlBVaUJVUlZOVUlGQlZVbEJQVTBWVElFOU9URmt4SkRBaUJnTlYNCkJBTVRHMUJGVUZCUFRDQkJRME5GVTFNZ1VFOUpUbFFnVkVWVFZDQkRRUUlRQm9MV2REQTlNWEh6T2VzS1Vhd0pXREFKQmdVckRnTUMNCkdnVUFvSUdJTUJnR0NTcUdTSWIzRFFFSkF6RUxCZ2txaGtpRzl3MEJCd0V3SEFZSktvWklodmNOQVFrRk1ROFhEVEUxTVRJd01URTANCk1UY3hPVm93SXdZSktvWklodmNOQVFrRU1SWUVGTFJlMDFLNFhraGtZeElBN2Q2WXlSWjhlRHdmTUNrR0NTcUdTSWIzRFFFSk5ERWMNCk1Cb3dDUVlGS3c0REFob0ZBS0VOQmdrcWhraUc5dzBCQVFFRkFEQU5CZ2txaGtpRzl3MEJBUUVGQUFTQ0FRQk4yTlNpc0YwWGhab2kNCm5QOGNHUzlkYlllRDExL05kaGZGRXFjbnJZRm50aUpVN1N2WUt4bXZrYXI4cFBGbVVGRWEwbjZQR0k2WFI2WVVYUlNzZ0o4RTFCdDYNCjh5bjdUNGQzNVR4UDU5TjdKeEdTU1VVWE04UEdwWVpldCtlMnQva1VybWFET3JIZHd2bGlXM2dhVWRaYXVTTzQvL2pXMEZGWFByck8NClBYaXpFL0VtbHo4VnVtTEdVUEx1K3BiZkJxbTNrRE5TQnU3aGV0TncySHlKTU5BYU1aM0lpN1pHakh6TjkrMVdqMGlYNmRxOE9zNkINCmZDOUZNWnNiQjErSXR2eFV5Slh6TjdONEZIYlYvYnVHN2VGc05pb3ZDc2FTZC80MHhqZjhhQ3ZnZlV3U3VOd1VQRmthSFE5eGFmNysNCitvTEN0M0svVHpIWXN6Y25TWnRKVXlZYUFBQUFBQUFBDQotLS0tLS09X1BhcnRfMl8zMzE0MTg1MDMuMTQ0ODk3OTQzODk2My0tDQo=