Skip to content

Commit

Permalink
Slight modifications to the readme file to emphasise that our impleme…
Browse files Browse the repository at this point in the history 
…ntation is agnostic with regards to the underlying protocol.
  • Loading branch information
Steinar Overbeck Cook committed Feb 8, 2016
1 parent d8b14c3 commit cb02084
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 2 deletions.
6 changes: 5 additions & 1 deletion peppol-evidence/README.md
View file
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,11 @@ This module contains an implementation of the ETSI TS 102 640-2 V2.1.1 also know
The XML Schema originally provided by ETSI has been modified:

* Slight adjustments made by Jörg Apitzsch
* Inclusion of PEPPOL AS2 MDN receipts in the ```Extensions``` element.
* Inclusion of protocol specific transport evidence represented by for instance PEPPOL AS2 MDN or AS4 Soap headers in the ```Extensions``` element.

**NOTE!** The transport protocol evidence is included as a stream of Base64 bytes in order to preserve white space etc., which must not be changed in order to preserve any
digital signatures.



## Getting started
Expand Down
2 changes: 1 addition & 1 deletion peppol-evidence/src/main/java/no/difi/vefa/peppol/evidence/rem/RemEvidenceTransformer.java
View file
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ public void toUnformattedXml(SignedRemEvidence signedRemEvidence, OutputStream o
}

/**
* Transforms the supplied signed REM Evidence into it's XML representation.
* Transforms the supplied signed REM Evidence into it's formatted XML representation.
* <p>
* NOTE! Do not use this XML representation for signature validation as this will fail.
*/
Expand Down

2 comments on commit cb02084

@Chanderbhan
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Question:
Is the time mentioned in the tranport evidence protocol exactly the same as the time mentioned in the REM Evidence?

@steinarcook
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This library is agnostic regarding the underlying transmission protocol. The user of this component must extract the pertinent information from the transport protocol evidence and supply it to the REM evidence builder. This library makes no assumption with regards to the time stamp in the transport evidence, as this information is simply injected as a stream of bytes.

Please sign in to comment.