Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ROU-11053: Fixed A11Y issues at the menu when @Mobile and others #986

Merged
merged 16 commits into from
Sep 9, 2024
Merged

ROU-11053: Fixed A11Y issues at the menu when @Mobile and others #986

Show file tree
Hide file tree
Changes from 13 commits
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
0db0ead
Update Menu.ts
gnbm Aug 23, 2024
7a20ef2
Merge branch 'dev' into ROU-11053
gnbm Aug 23, 2024
ca38c80
Update MenuFocusableElems expression
gnbm Aug 27, 2024
c04dd29
Merge branch 'dev' into ROU-11053
gnbm Aug 27, 2024
15cd127
Update Menu.ts
gnbm Aug 28, 2024
6b18e4f
Add onResize event
gnbm Aug 28, 2024
00a7c51
Update Menu.ts
gnbm Aug 28, 2024
801f4d8
Merge branch 'dev' into ROU-11053
joselrio Sep 3, 2024
f115925
Update settings.json
joselrio Sep 3, 2024
8c4798e
Revamped Menu implementation to improve A11Y
joselrio Sep 5, 2024
39f1eb8
Turn property into private
joselrio Sep 6, 2024
ed21e5d
Stop the propagation of the keypressEvent
joselrio Sep 6, 2024
38b2ff3
Fixed show and hide menu client actions api.
joselrio Sep 6, 2024
750ff3f
Prevent to "show" the menu when at wrong context.
joselrio Sep 6, 2024
360b863
update based on feedback
joselrio Sep 6, 2024
3984801
Fix issue when screen change.
joselrio Sep 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .vscode/settings.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"diffEditor.ignoreTrimWhitespace": true,
"files.autoSave": "afterDelay",
"files.autoSave": "off",
"editor.minimap.maxColumn": 170,
"editor.wordWrapColumn": 170,
"editor.formatOnSave": true,
Expand Down
2 changes: 2 additions & 0 deletions src/scripts/OSFramework/OSUI/Pattern/Submenu/Submenu.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,6 +74,8 @@ namespace OSFramework.OSUI.Patterns.Submenu {

// Call methods to close, based ok e.key
private _keypressBalloonCallback(e: KeyboardEvent): void {
e.stopPropagation();

// Close the submenu when pressing Esc
if (e.key === GlobalEnum.Keycodes.Escape && this._isOpen) {
this.close();
Expand Down
Loading