-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ROU-11053: Fixed A11Y issues at the menu when @Mobile and others #986
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: José Rio <[email protected]>
BenOsodrac
requested changes
Sep 6, 2024
BenOsodrac
previously approved these changes
Sep 6, 2024
JoaoFerreira-FrontEnd
previously approved these changes
Sep 9, 2024
joselrio
dismissed stale reviews from JoaoFerreira-FrontEnd and BenOsodrac
via
September 9, 2024 13:38
3984801
Quality Gate passedIssues Measures |
BenOsodrac
approved these changes
Sep 9, 2024
JoaoFerreira-FrontEnd
approved these changes
Sep 9, 2024
joselrio
added a commit
that referenced
this pull request
Sep 10, 2024
… (#987) * Update Menu.ts * Update MenuFocusableElems expression * Update Menu.ts * Add onResize event * Update Menu.ts * Update settings.json * Revamped Menu implementation to improve A11Y * Turn property into private * Stop the propagation of the keypressEvent * Fixed show and hide menu client actions api. * Prevent to "show" the menu when at wrong context. * update based on feedback * Fix issue when screen change. --------- Co-authored-by: gnbm <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will fix several issues at the menu, mostly A11Y related...
What was happening
What was done
Keyboard navigation issues after a resize into mobile devices resolutions and Menu be as a mobile menu:
Submenu once inside a menu is being trap the user during keyboard navigation:
MenuShow and MenuHide APIs: