Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ROU-11053: Fixed A11Y issues at the menu when @Mobile and others #986

Merged
merged 16 commits into from
Sep 9, 2024

Conversation

joselrio
Copy link
Contributor

@joselrio joselrio commented Sep 6, 2024

This PR will fix several issues at the menu, mostly A11Y related...

What was happening

  • Keyboard navigation issues after a resize into mobile devices resolutions and Menu be as a mobile menu (sidebar menu);
  • Submenu once inside a menu is being trap the user during keyboard navigation;
  • MenuShow and MenuHide APIs not working;

What was done

Keyboard navigation issues after a resize into mobile devices resolutions and Menu be as a mobile menu:

  • User was getting keyboard navigation issues due the missing of update a11y attributes and events;
  • User was able to navigate through the elements but without being trapped at the menu context, again, due to the missing update of the a11y attributes;

Submenu once inside a menu is being trap the user during keyboard navigation:

  • Once the keyboard navigation was in use and a submenu item was opened by the user keypress action, user was being trapped inside it due the focus trap inside the submenu context, now, user will be able to close the submenu item and continue to navigate through the elements at the menu;

MenuShow and MenuHide APIs:

  • This methods was not working to the current layout versions due the missing of a selector that do not exist. Also fixed it in a way to look at the deprecated element and if not exist it will take the current layout menu. Deprecated should be there in order to grant old layouts will not stop working as expected;

@joselrio joselrio requested a review from a team as a code owner September 6, 2024 14:39
src/scripts/OutSystems/OSUI/Utils/Menu.ts Outdated Show resolved Hide resolved
src/scripts/OutSystems/OSUI/Utils/Menu.ts Outdated Show resolved Hide resolved
BenOsodrac
BenOsodrac previously approved these changes Sep 6, 2024
Copy link

sonarqubecloud bot commented Sep 9, 2024

@joselrio joselrio changed the base branch from dev to ROU-11053-v2 September 9, 2024 18:42
@joselrio joselrio merged commit 02bb4fc into ROU-11053-v2 Sep 9, 2024
14 checks passed
@joselrio joselrio deleted the ROU-11053 branch September 9, 2024 18:42
joselrio added a commit that referenced this pull request Sep 10, 2024
… (#987)

* Update Menu.ts

* Update MenuFocusableElems expression



* Update Menu.ts

* Add onResize event

* Update Menu.ts

* Update settings.json

* Revamped Menu implementation to improve A11Y

* Turn property into private

* Stop the propagation of the keypressEvent

* Fixed show and hide menu client actions api.

* Prevent to "show" the menu when at wrong context.

* update based on feedback

* Fix issue when screen change.

---------

Co-authored-by: gnbm <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants