Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RMET-3602 ::: Updated libs for 16KB page alignment #33

Merged

Conversation

OS-pedrogustavobilro
Copy link
Collaborator

@OS-pedrogustavobilro OS-pedrogustavobilro commented Nov 8, 2024

Description

Update mlkit and camera libraries to latest version, that have their shared libraries (.so files) 16KB-aligned.

Note that libsqlc-ndk-native-driver.so is not 16KB-aligned, and any app that uses it crashes, that is because the SQL Cypher library needs to be updated - out of scope of this repo.

Context

Type of changes

  • Fix (non-breaking change which fixes an issue)
  • Feature (non-breaking change which adds functionality)
  • Refactor (cosmetic changes)
  • Breaking change (change that would cause existing functionality to not work as expected)

Platforms affected

  • Android
  • iOS
  • JavaScript

Tests

Steps:

  1. Generate a MABS11 build with barcode plugin pointing to the latest released version
  2. Run check_elf_alignment.sh script: ./check_elf_alignment.sh <apk_file> | grep arm64-v8a
/var/folders/ln/4t6dd54d3c1b3wm92vv9pggc0000gn/T/barcode-MABS11-no16kb_out_XXXXX.23adACzP6z/lib/arm64-v8a/libsqlc-ndk-native-driver.so: \e[31mUNALIGNED\e[0m (2**12)
/var/folders/ln/4t6dd54d3c1b3wm92vv9pggc0000gn/T/barcode-MABS11-no16kb_out_XXXXX.23adACzP6z/lib/arm64-v8a/libbarhopper_v3.so: \e[31mUNALIGNED\e[0m (2**12)
/var/folders/ln/4t6dd54d3c1b3wm92vv9pggc0000gn/T/barcode-MABS11-no16kb_out_XXXXX.23adACzP6z/lib/arm64-v8a/libimage_processing_util_jni.so: \e[31mUNALIGNED\e[0m (2**12
  1. Point the plugin version (in Extensibility Configuration) to this branch.
  2. Run again ./check_elf_alignment.sh <apk_file> | grep arm64-v8a - ".so" files associated with mlkit and camera should be aligned
/var/folders/ln/4t6dd54d3c1b3wm92vv9pggc0000gn/T/barcode-MABS11-RMET-3602_out_XXXXX.rNDCwvBYgp/lib/arm64-v8a/libsqlc-ndk-native-driver.so: \e[31mUNALIGNED\e[0m (2**12)
/var/folders/ln/4t6dd54d3c1b3wm92vv9pggc0000gn/T/barcode-MABS11-RMET-3602_out_XXXXX.rNDCwvBYgp/lib/arm64-v8a/libbarhopper_v3.so: \e[32mALIGNED\e[0m (2**14)
/var/folders/ln/4t6dd54d3c1b3wm92vv9pggc0000gn/T/barcode-MABS11-RMET-3602_out_XXXXX.rNDCwvBYgp/lib/arm64-v8a/libimage_processing_util_jni.so: \e[32mALIGNED\e[0m (2**14)

Checklist

  • Pull request title follows the format RMET-XXXX <title>
  • Code follows code style of this project
  • CHANGELOG.md file is correctly updated
  • Changes require an update to the documentation
    • Documentation has been updated accordingly

@alexgerardojacinto
Copy link
Contributor

@OS-pedrogustavobilro we should also update the gradle dependency to the OSBarcodeLib-Android library right?

@OS-pedrogustavobilro
Copy link
Collaborator Author

@OS-pedrogustavobilro we should also update the gradle dependency to the OSBarcodeLib-Android library right?

Yeah @alexgerardojacinto it was done in this PR - OutSystems/OSBarcodeLib-Android#38 (already merged). Or do you mean some other dependency?

@OS-pedrogustavobilro OS-pedrogustavobilro merged commit 59d71b9 into development Nov 13, 2024
4 checks passed
@OS-pedrogustavobilro OS-pedrogustavobilro deleted the fix/RMET-3602/android15-16KB-page-size branch November 13, 2024 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants