Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RMET-3602 ::: Updated libs for 16KB page alignment #38

Merged

Conversation

OS-pedrogustavobilro
Copy link
Collaborator

@OS-pedrogustavobilro OS-pedrogustavobilro commented Nov 8, 2024

Description

Update mlkit and camera libraries to latest version, that have their shared libraries (.so files) 16KB-aligned.

The actual fix is in OutSystems/cordova-outsystems-barcode#33 - this is more to make sure the dependency versions are aligned.

Context

Type of changes

  • Fix (non-breaking change which fixes an issue)
  • Feature (non-breaking change which adds functionality)
  • Refactor (cosmetic changes)
  • Breaking change (change that would cause existing functionality to not work as expected)

Platforms affected

  • Android
  • iOS
  • JavaScript

Tests

Refer to OutSystems/cordova-outsystems-barcode#33

Checklist

  • Pull request title follows the format RNMT-XXXX <title>
  • Code follows code style of this project
  • CHANGELOG.md file is correctly updated
  • Changes require an update to the documentation
    • Documentation has been updated accordingly

@alexgerardojacinto
Copy link
Collaborator

@OS-pedrogustavobilro we should also update the version of the library in the pom.xml file so we can update and test it in the Cordova plugin.

@OS-pedrogustavobilro
Copy link
Collaborator Author

@alexgerardojacinto can't reply directly to your comment don't know why.

I updated the dependencies on the cordova plugin, since it was already declared there, so technically we don't need to generate a new .aar - Just pointing to the branch of this PR is enough OutSystems/cordova-outsystems-barcode#33

@alexgerardojacinto
Copy link
Collaborator

@alexgerardojacinto can't reply directly to your comment don't know why.

I updated the dependencies on the cordova plugin, since it was already declared there, so technically we don't need to generate a new .aar - Just pointing to the branch of this PR is enough OutSystems/cordova-outsystems-barcode#33

@OS-pedrogustavobilro we will need to generate a new .aar with these changes so that we can update the .aar version that is referenced in the Cordova plugin. We don't need to generate the .aar right now, but we should update the version of the library in the pom.xml file.

@OS-pedrogustavobilro OS-pedrogustavobilro merged commit b6b5292 into development Nov 12, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants