cpu-o3: fix a memory leak problem #274
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tastynoob
approved these changes
Jan 21, 2025
|
Should delete pkt only when sig was hint or bus_clear |
Yes I will fix it, the packet used by the hint is the packet from the |
happy-lx
force-pushed
the
fix-bus-clear
branch
3 times, most recently
from
a286de2 to
a5e538a
Compare
After the cache refills the data, it sends a `Bus_Clear` packet to notify the LSU. This should only be sent by the Dcache, and neither L2 nor L3 should send this packet. Calling `recvFunctionalCustomSignal` on the xbar does nothing, causing the custom packet to be lost, leading to a memory leak. Change-Id: Ie735660b66536908633daa6c25d76b7127add0b9
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After the cache refills the data, it sends a custom
Bus_Clearpacket to notify the LSU. This should only be sent by the Dcache, and neither L2 nor L3 should send this packet.Calling
recvFunctionalCustomSignalon the xbar does nothing, causing the custom packet to be lost, leading to a memory leak.Thanks to @tastynoob finding this problem
Change-Id: Ie735660b66536908633daa6c25d76b7127add0b9