Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @bovirus , what is "L'allegato alla connessione automatica" ? Does it come from the English version? (I haven't checked it yet)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
English version is
IDS_ERR_PARSE_MGMT_OPTION "Could not parse --management option in <%ls%ls>. \ Attaching to auto-started connections require --management option in the config file."
The second line was added yesterday which prompted this update.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @selvanair , then this translation is wrong. The word "allegato", being used in the proposed translation, means "(email) attachment" and this is not the meaning that "attach" has in this context.
To be honest I can't think of what the correct translation should be right now.
@bovirus in this context you should read "Attaching" more like "Collegarsi" or "Legarsi", but none of them would work imho. Maybe you have a better suggestion?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@selvanair shouldn't the English version be "requireS" rather than "require"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"Attaching to auto-started connections" could be interpreted as "Controlling auto-started connections using the GUI" if that helps in translation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah! I think that helps. @bovirus how about starting from this one?
@selvanair imho that'd be a better English text too. The average Joe is less likely to understand "Attaching" here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is shown when the user clicks "connect" in the GUI menu against a config that is started by the "openvpnservice" at boot. So somehow indicating that
--management
option is required in this case unlike connections started and stopped by the GUI is an improvement. "Attaching", "Controlling" or something else all refer to what the user is trying to do: which is "try to see the connection status using the GUI". So I think any of those words would work here.