Prefer Liberty SCC to OpenJ9 SCC #204
Conversation
|
This patch assumes that we want to use the SCC in the OpenJ9 container as the base SCC layer and add OpenLiberty SCC layers on top. The IBM JDK does not (currently) ship with an SCC so for that case we'll maintain the old behaviour of building the OL SCC layers in the old |
|
Also, I left the older |
ymanton
force-pushed
the
multi-layer-SCC
branch
from
17c40f9 to
2ab81b2
Compare
|
Added a workaround for the problem mentioned in #203 (comment) (FYI @jdmcclur). Details are in the patch, smells like a Linux and/or Docker bug, but root cause is not yet clear. |
ymanton
force-pushed
the
multi-layer-SCC
branch
from
2ab81b2 to
d425f71
Compare
|
Workaround is insufficient. Subsequent Docker layers hit the same issue. It's possible that applying workarounds at each Docker layer would "fix" it, but at this point it's not worth compounding a less than ideal fix just to get it working so we're going to ignore the OpenJ9 SCC for the time being and continue to build Liberty SCC layers. We can revisit once the root cause of the problem is found. The new patch ignores the incoming SCC settings from the OpenJ9 image and overrides them with the existing Liberty options. I've also back-ported the changes to the 20.0.0.x releases after getting feedback offline to #204 (comment). |
|
LGTM, also will need a PR for the WebSphere Liberty images, right? |
On some systems trying to use the OpenJ9 SCC leads to permission denied errors, despite file permissions being observably correct. For the time being we'll ignore the OpenJ9 SCC and continue to build our own SCC layers. In order to do this we switch to setting/using the OPENJ9_JAVA_OPTIONS env var in order to override the OpenJ9 image and move away from IBM_JAVA_OPTIONS, which is deprecated anyway. Signed-off-by: Younes Manton <[email protected]>
ymanton
force-pushed
the
multi-layer-SCC
branch
from
d425f71 to
b8d78a9
Compare
|
Missed updating
Yes, I have a PR for that which I'll open once this patch starts looking final. |
|
What happens if the user wants to set his/her own options when running the container with |
|
Yes, it will overwrite the existing env vars. If the user wants to only add to the existing options they'll have to retrieve the existing ones and append theirs. This is true for the OpenJ9 images as well. |
Which is why I opened AdoptOpenJDK/openjdk-docker#402
This is far from ideal. As soon as all the usability fixes get delivered at adopt we need to revert this PR. |
|
@arthurdm This PR is ready for your review. Thanks |
OpenJ9 images now ship with an SCC that we can use as a base SCC layer.
Fixes #203
FYI @jdmcclur, can you give this patch a try?