Prefer Liberty SCC to OpenJ9 SCC #360
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On some systems trying to use the OpenJ9 SCC leads to permission denied errors, despite file permissions being observably correct. For the time being we'll ignore the OpenJ9 SCC and continue to build our own SCC layers. In order to do this we switch to setting/using the OPENJ9_JAVA_OPTIONS env var in order to override the OpenJ9 image and move away from IBM_JAVA_OPTIONS, which is deprecated anyway. Signed-off-by: Younes Manton <[email protected]>
|
@ymanton Noticed that the WL change has this line, while OL PR doesn't. Is that intentional? If so, wondering what's the reason for it. Thanks.
|
arthurdm
approved these changes
Oct 6, 2020
|
sorry @leochr - I didn't see your comment before I started to review. Let me know if you think this should be reopened. |
|
No worries Arthur. Checked with Younes regarding the above comment about IBM_JAVA_OPTIONS and confirmed there isn't anything else needed for OL/WL: Thank you @ymanton for the fix! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: This fix corresponds to a similar one in Open Liberty: OpenLiberty/ci.docker#204.
On some systems trying to use the OpenJ9 SCC leads to
permission denied errors, despite file permissions being
observably correct.
For the time being we'll ignore the OpenJ9 SCC and
continue to build our own SCC layers. In order to do this
we switch to setting/using the OPENJ9_JAVA_OPTIONS
env var in order to override the OpenJ9 image and move
away from IBM_JAVA_OPTIONS, which is deprecated anyway.
Signed-off-by: Younes Manton [email protected]