Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Produce a more descriptive error when validation server url is not set to a WS/WSS server #2475

Merged
merged 6 commits into from
Jul 12, 2024

Conversation

ganeshvanahalli
Copy link
Contributor

Resolves NIT-1314

@cla-bot cla-bot bot added the s Automatically added by the CLA bot if the creator of a PR is registered as having signed the CLA. label Jul 10, 2024
@joshuacolvin0 joshuacolvin0 dismissed a stale review July 11, 2024 16:25

not valid

gligneul
gligneul previously approved these changes Jul 12, 2024
Copy link
Member

@joshuacolvin0 joshuacolvin0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ganeshvanahalli ganeshvanahalli merged commit 9ccd934 into master Jul 12, 2024
13 checks passed
@ganeshvanahalli ganeshvanahalli deleted the descriptive-error-httpvalidationserver branch July 12, 2024 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design-approved s Automatically added by the CLA bot if the creator of a PR is registered as having signed the CLA.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants