Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Produce a more descriptive error when validation server url is not set to a WS/WSS server #2475

Merged
merged 6 commits into from
Jul 12, 2024
Merged

Produce a more descriptive error when validation server url is not set to a WS/WSS server #2475

Changes from 3 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
8daee6e
Produce a more descriptive error when validation server url is not se…
ganeshvanahalli Jul 10, 2024
bca0114
address PR comments
ganeshvanahalli Jul 11, 2024
85786d2
Merge branch 'master' into descriptive-error-httpvalidationserver
ganeshvanahalli Jul 11, 2024
783f12f
address PR comments
ganeshvanahalli Jul 12, 2024
67b23a9
Merge branch 'master' into descriptive-error-httpvalidationserver
ganeshvanahalli Jul 12, 2024
d5facad
Merge branch 'master' into descriptive-error-httpvalidationserver
ganeshvanahalli Jul 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion staker/stateless_block_validator.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ import (
"context"
"errors"
"fmt"
"net/url"
"testing"

"github.com/offchainlabs/nitro/arbstate/daprovider"
Expand Down Expand Up @@ -428,8 +429,13 @@ func (v *StatelessBlockValidator) Start(ctx_in context.Context) error {
return fmt.Errorf("starting execution spawner: %w", err)
}
}
for _, spawner := range v.execSpawners {
for i, spawner := range v.execSpawners {
if err := spawner.Start(ctx_in); err != nil {
if u, parseErr := url.Parse(v.config.ValidationServerConfigs[i].URL); parseErr == nil {
if u.Scheme == "http" || u.Scheme == "https" {
ganeshvanahalli marked this conversation as resolved.
Show resolved Hide resolved
return fmt.Errorf("validation server's url scheme is unsupported, it should either be ws or wss, url:%s err: %w", v.config.ValidationServerConfigs[i].URL, err)
}
}
return err
}
}
Expand Down
Loading