Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Welsh translation for cookies page #59

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

hbrace
Copy link
Contributor

@hbrace hbrace commented Dec 20, 2024

Motivation and Context

There was some missing translation on the Welsh cookies page

What has changed

Translation added

How to test?

make build and start in your own env
Check the page and ensure the text matches the document attached to the Jira card
Run ATs

Links

https://jira.ons.gov.uk/browse/SDCSRM-383

Screenshots (if appropriate)

@hbrace hbrace added the patch A non-feature change, e.g. bug or issue fix label Dec 20, 2024
Copy link

Copy link
Contributor

@ryangrundy7 ryangrundy7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Translations looks good 👍 Only difference I can see is what they've said for on and off which doesn't match the others. Maybe a question for Louise but I don't think it's an issue.

@hbrace hbrace added the do not merge Do not merge this pull request label Dec 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do not merge Do not merge this pull request patch A non-feature change, e.g. bug or issue fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants