Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TASK] Fix Lighthouse failures - address-input #215

Closed
MagdalenaLarge opened this issue Sep 19, 2024 · 0 comments · Fixed by ONSdigital/design-system#3405
Closed

[TASK] Fix Lighthouse failures - address-input #215

MagdalenaLarge opened this issue Sep 19, 2024 · 0 comments · Fixed by ONSdigital/design-system#3405

Comments

@MagdalenaLarge
Copy link

MagdalenaLarge commented Sep 19, 2024

Alessio addressed Lighthouse failure in the ticket #3350.

As an outcome of the above ticket, identified a need to address the warnings for address input component. It relates to accessibility.

1 result(s) for http://localhost:39203/components/address-input/example-address-input.html :
1 result(s) for http://localhost:39203/patterns/addresses/example-address-input-non-editable.html :

Action
Use yarn start and then move onto the above components in order. Use the lighthouse test from the google chrome dev tools. Run the test on the component and only look at the accessibility score. Fix the issues highlighted under the accessibility section. Run the test again and confirm that they are now at 100. Move on to the next component.

@MagdalenaLarge MagdalenaLarge changed the title [TASK] Fix Lighthouse failures [TASK] Fix Lighthouse failures - address-input Sep 23, 2024
@rmccar rmccar self-assigned this Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants