Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix lighthouse address input test #3405

Merged
merged 2 commits into from
Oct 29, 2024
Merged

Conversation

rmccar
Copy link
Contributor

@rmccar rmccar commented Oct 24, 2024

What is the context of this PR?

Fixes: ONSdigital/design-team#215

This change adds an id to the warning container so that when the warning is displayed the aria-owns and aria-controls attributes on the input have valid values because the id will now exist on the page and not just when there is no error. Before this the results container had an id but the error panel didnt.

How to review this PR

  • Check the lighthouse tests in the github actions and see that the result for the test for the example-address-input example is now 100
  • Also run the test locally on this branch in chrome and on the main branch to see that this issue is now fixed.

Checklist

This needs to be completed by the person raising the PR.

  • I have selected the correct Assignee
  • I have linked the correct Issue

@rmccar rmccar added the Accessibility Issues discovered through accessibility testing label Oct 24, 2024
@rmccar rmccar self-assigned this Oct 24, 2024
Copy link

netlify bot commented Oct 24, 2024

Deploy Preview for ons-design-system-preview ready!

Name Link
🔨 Latest commit a81ff32
🔍 Latest deploy log https://app.netlify.com/sites/ons-design-system-preview/deploys/671a6a6490d5f80008f8b133
😎 Deploy Preview https://deploy-preview-3405--ons-design-system-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@rmccar rmccar changed the title Fix lighthouse address input error Fix lighthouse address input test Oct 24, 2024
@rmccar rmccar requested a review from a team October 25, 2024 08:01
@rmccar rmccar merged commit f350c1d into main Oct 29, 2024
45 checks passed
@rmccar rmccar deleted the fix-lighthouse-address-input-error branch October 29, 2024 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Accessibility Issues discovered through accessibility testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[TASK] Fix Lighthouse failures - address-input
3 participants