Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TASK] Change Lighthouse configuration #221

Open
MagdalenaLarge opened this issue Sep 23, 2024 · 3 comments
Open

[TASK] Change Lighthouse configuration #221

MagdalenaLarge opened this issue Sep 23, 2024 · 3 comments

Comments

@MagdalenaLarge
Copy link

MagdalenaLarge commented Sep 23, 2024

Description

Currently we are getting a warning in Lighthouse while doing the testing, but we do not get error message.
It means that errors are quite often missed.

Action
Investigate what is causing lack of error messages in the Lighthouse and fix it so any future issues are highlighted in error message

Ticket depends on completion of the tickets #215 , #216 , #217 , #218 , #219 .

Once you have finished with all above components change the below code from the lighthouse/lighthouserc.js :

OLD

assert: {
    assertions: {
        'categories:accessibility': ['warn', { minScore: 1 }],
    },
},

NEW

assert: {
    assertions: {
        'categories:accessibility': ['error', { minScore: 1 }],
    },
},
@rmccar
Copy link

rmccar commented Oct 31, 2024

Blocked waiting for other PRs to be merged

@rmccar
Copy link

rmccar commented Nov 4, 2024

The scope of this ticket will need to be extended to look into ignoring the issues we have with the setting of the aria-expanded attribute on radios. This is covered in #216

@rmccar
Copy link

rmccar commented Nov 7, 2024

Blocked waiting on outcome of #216

@admilne admilne added In development To make the issue appear in 'working on now' on the Service Manual and removed In development To make the issue appear in 'working on now' on the Service Manual labels Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants