Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add padding and margin utility classes without important #3437

Merged

Conversation

admilne
Copy link
Contributor

@admilne admilne commented Nov 22, 2024

Ticket: ONSDESYS-195

Adds the ability to remove !important when setting utility classes for padding and margins.

How to review this PR

  • This can be tested by adding a margin or padding utility class to a component and then adding -not-important to the end to check the !important has been dropped from the style.

Checklist

This needs to be completed by the person raising the PR.

  • I have selected the correct Assignee
  • I have linked the correct Issue

@admilne admilne added the Enhancement Change of existing feature label Nov 22, 2024
@admilne admilne requested a review from a team November 22, 2024 09:29
@admilne admilne self-assigned this Nov 22, 2024
Copy link

netlify bot commented Nov 22, 2024

Deploy Preview for ons-design-system-preview ready!

Name Link
🔨 Latest commit 15f0460
🔍 Latest deploy log https://app.netlify.com/sites/ons-design-system-preview/deploys/67407f97be9f990008a7fe93
😎 Deploy Preview https://deploy-preview-3437--ons-design-system-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@admilne admilne merged commit 5dd5702 into main Nov 22, 2024
25 checks passed
@admilne admilne deleted the task/ONSDESYS-195/update-padding-and-margin-utility-classes branch November 22, 2024 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement Change of existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants