Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TASK] Update padding and margin utility classes with the ability to remove !important #223

Closed
rmccar opened this issue Oct 25, 2024 · 1 comment
Assignees
Labels
Medium Priority Tech improvements Tech debt, cleanup, code standardisation etc.

Comments

@rmccar
Copy link

rmccar commented Oct 25, 2024

Description
To be able to reuse utility classes across the DS where we set padding and margins individually we need in some cases the ability to remove !important from the classes so that it doesn't override some styles we don't want it to in some cases.

Task
Add the ability to remove !important when setting utility classes for padding and margins. This would be achieved through adding some text to the end of the class name which would then automatically set the utility class styling without the !important on the end.

@rmccar
Copy link
Author

rmccar commented Nov 27, 2024

Fixed in ONSdigital/design-system#3437

@rmccar rmccar closed this as completed Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Medium Priority Tech improvements Tech debt, cleanup, code standardisation etc.
Projects
None yet
Development

No branches or pull requests

4 participants