Fixed Lighthouse testing local and in CI #3355
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for ons-design-system-preview ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
…ital/design-system into fix/3350/lighthouse-tests-failing
rmccar
approved these changes
Sep 18, 2024
alessioventuriniAND
changed the title
SriHV
approved these changes
Sep 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the context of this PR?
This fixes : #3350
I have now fixed our lighthouse tests. They can be run locally and they also run in the pipeline. We currently have some components that don't have a 100 score in the accessibility parameter of lighthouse. I will get a ticket raised to address those components changes and update our lighthouse tests to return an error rather than a warning so if one of our components is not 100 accessible the test will fail.
How to review this PR
Run the newly added test-lighthouse command and confirm that the tests run locally.
Checklist
This needs to be completed by the person raising the PR.