Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Lighthouse tests failing even though actions pass #3350

Closed
rmccar opened this issue Sep 13, 2024 · 0 comments · Fixed by #3355
Closed

[Bug]: Lighthouse tests failing even though actions pass #3350

rmccar opened this issue Sep 13, 2024 · 0 comments · Fixed by #3355
Assignees
Labels
Bug Something isn't working Community backlog An issue raised on the community backlog High priority

Comments

@rmccar
Copy link
Contributor

rmccar commented Sep 13, 2024

Describe the bug

The lighthouse github action is passing on PRs but the Lighthouse tests themselves are failing

Expected behaviour / outcome

Lighthouse tests pass and if they do fail then the action fails

List the steps necessary to reproduce the bug

Look at the Lighthouse GitHub action logs and see that the tests are failing

Additional context

Will need to fix the tests but also fix the action so that it fails when the tests fail

What version of the ONS Design System are you using?

70.0.15

What device(s) are you using?

Desktop

What operating system(s) are you using?

macOS

What browser(s) are you using?

Chrome

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working Community backlog An issue raised on the community backlog High priority
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants