Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
2753 error panel needs extending to accept two errors for one input #2817
2753 error panel needs extending to accept two errors for one input #2817
Changes from 3 commits
a07f2cf
5035190
35e6ea8
9fbfd75
0d57d60
f158fa7
b98b4d8
342e888
d3f3303
fc7f2fb
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To show the functionality I think we only need one date input and just have it ask for date of birth or something would make it simpler as the extra date input isn't really adding anything. Or could just use a single regular input with 2 problems with the answer might be even better as this isn't only going to be used on components with more than one input
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The example now no longer makes sense because you have a period from but no period to.
I think an example based on this would be good as its a real eQ example of what would happen in a real questionnaire.