2753 error panel needs extending to accept two errors for one input #2817
Conversation
precious-onyenaucheya-ons
requested review from
rmccar,
adi-unni and
alessioventuriniAND
✅ Deploy Preview for ons-design-system-preview ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
…wo-errors-for-one-input
| {{ | ||
| onsDateInput({ | ||
| "id": "period-from-date", | ||
| "legendOrLabel": "Period from:", | ||
| "description": "For example, 31 3 2019", | ||
| "day": { | ||
| "label": { | ||
| "text": "Day" | ||
| }, | ||
| "name": "day", | ||
| "value": "31" | ||
| }, | ||
| "month": { | ||
| "label": { | ||
| "text": "Month" | ||
| }, | ||
| "name": "month", | ||
| "value": "13" | ||
| }, | ||
| "year": { | ||
| "label": { | ||
| "text": "Year" | ||
| }, | ||
| "name": "year", | ||
| "value": "2018" | ||
| } | ||
| }) | ||
| }} |
There was a problem hiding this comment.
To show the functionality I think we only need one date input and just have it ask for date of birth or something would make it simpler as the extra date input isn't really adding anything. Or could just use a single regular input with 2 problems with the answer might be even better as this isn't only going to be used on components with more than one input
There was a problem hiding this comment.
The example now no longer makes sense because you have a period from but no period to.
I think an example based on this would be good as its a real eQ example of what would happen in a real questionnaire.
src/patterns/correct-errors/example-error-proto-multiple-error-per-input.njk
Outdated
Show resolved
Hide resolved
|
Might be something you want to check with Dina but I think the spacing has changed when making this a list compared to a panel with a single error. This extra margin-top that has been added because it is now a list might need removing and the margin bottom added at the bottom of the list might need increasing to match 
|
What is the context of this PR?
This fixes #2753. This ticket ensures that the error panel accepts multiple errors for a single input. Users can now enter a list of errors for a single input.
How to review this PR
Check that the error panel component can accept multiple error message as well as a single one.
Checklist
This needs to be completed by the person raising the PR.