Verify module dependencies are installed #106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
azimov
requested changes
Dec 15, 2023
There was a problem hiding this comment.
Overall testing this seemed good - it was able to break a module and then that verification process failed (which should stop the whole analysis until it is user resolved, so that's good).
However, I have big concerns about the calls to privaterenv functions and its difficult for me to understand their usage and the implications of it.
|
@azimov Thanks for the review! The latest commit should address the issues you raised. Please let me know and hopefully this should be ready to merge. |
azimov
approved these changes
Dec 18, 2023
|
Happy with these changes now, just needs the conflicts to be resolved and should be ready to merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to address problems surfaced in #75 that will prevent Strategus from running an analysis if there are issues detected from restoring the dependencies via
renv::restore().