Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[14.0][IMP] l10n_it_ricevute_bancarie: Add exposure/risk and improve the management of unsolved riba #4457

Open
wants to merge 5 commits into
base: 14.0
Choose a base branch
from

Conversation

toita86
Copy link

@toita86 toita86 commented Nov 25, 2024

Back port di tutti i cambiamenti fatti nella PR #3984. Con piccoli riadattamenti per la 14.0

@francesco-ooops
Copy link
Contributor

@SirAionTech va bene che teniamo tutto in un solo commit o va gestito come una migrazione?

@toita86 toita86 force-pushed the 14.0-MIG-l10n_it_ricevute_bancarie-toita86 branch from 6f99361 to 7a71ef9 Compare November 25, 2024 11:00
@toita86 toita86 force-pushed the 14.0-MIG-l10n_it_ricevute_bancarie-toita86 branch from 7a71ef9 to 15bcfb8 Compare November 25, 2024 11:42
@toita86 toita86 marked this pull request as ready for review November 25, 2024 11:42
@francesco-ooops francesco-ooops linked an issue Nov 25, 2024 that may be closed by this pull request
2 tasks
@francesco-ooops francesco-ooops added 14.0 is porting This pull request is porting a change from another version labels Nov 25, 2024
@toita86 toita86 force-pushed the 14.0-MIG-l10n_it_ricevute_bancarie-toita86 branch from 15bcfb8 to 1514290 Compare November 26, 2024 08:08
@SirAionTech
Copy link
Contributor

@SirAionTech va bene che teniamo tutto in un solo commit o va gestito come una migrazione?

Secondo me devono essere portati i singoli commit come in una migrazione perché ognuno ha il suo scopo.

@odooNextev ti chiedo di revisionare perché la PR e i commit portati sono tuoi, come il nuovo commit in questa PR.

@toita86 toita86 force-pushed the 14.0-MIG-l10n_it_ricevute_bancarie-toita86 branch from 1514290 to 28b4471 Compare November 26, 2024 13:41
Copy link
Contributor

@aleuffre aleuffre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review, LGTM

Copy link
Contributor

@francesco-ooops francesco-ooops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Funzionale ok (testato da @stefano-ooops)

@francesco-ooops
Copy link
Contributor

@SirAionTech giusto un dubbio, la descrizione dei commit "l10n_it_riba" va modificata con il nome v14 del modulo o lasciamo così come da commit originale?

@SirAionTech
Copy link
Contributor

@SirAionTech giusto un dubbio, la descrizione dei commit "l10n_it_riba" va modificata con il nome v14 del modulo o lasciamo così come da commit originale?

Si va nelle aree grigie 😄 secondo me ci andrebbe il nome del modulo che si sta effettivamente modificando nel commit

Copy link

@MaurizioPellegrinet MaurizioPellegrinet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test Funzionale: OK

@toita86 toita86 force-pushed the 14.0-MIG-l10n_it_ricevute_bancarie-toita86 branch from 28b4471 to 6d9c241 Compare November 27, 2024 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
14.0 approved is porting This pull request is porting a change from another version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[IMP] l10n_it_riba: refactoring
7 participants