Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: R CMD BUILD of vignettes #104

Merged
merged 6 commits into from
Oct 22, 2024
Merged

fix: R CMD BUILD of vignettes #104

merged 6 commits into from
Oct 22, 2024

Conversation

akselthomsen
Copy link
Contributor

@akselthomsen akselthomsen commented Oct 21, 2024

This PR fixes some R CMD Build issues related to the vignettes:

Copy link

Github pages

Review the pkgdown webpage for the PR here

Copy link

Code coverage

Name Coverage (%)
whirl 59.88
R/approvedpkgs.R 0.00
R/custom_logging.R 63.04
R/enrich_input.R 100.00
R/internal_run.R 100.00
R/mdformats.R 0.00
R/normalize_with_base.R 100.00
R/pb_script.R 43.75
R/quarto.R 95.24
R/read_regexp.R 93.33
R/render_summary.R 94.12
R/renv.R 0.00
R/run.R 100.00
R/session.R 79.86
R/status.R 91.30
R/strace.R 0.00
R/util_queue_summary.R 100.00
R/whirl_queue.R 94.12
R/whirl_r_session.R 82.11
R/zzz.R 0.00

@akselthomsen akselthomsen added bug Something isn't working enhancement New feature or request labels Oct 21, 2024
@akselthomsen akselthomsen requested a review from falgreen October 21, 2024 14:13
@akselthomsen akselthomsen marked this pull request as ready for review October 21, 2024 14:13
Copy link
Contributor

@falgreen falgreen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@falgreen falgreen merged commit 551940d into main Oct 22, 2024
13 of 14 checks passed
@akselthomsen akselthomsen deleted the debug-vignette-example-build branch October 24, 2024 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants