-
-
Notifications
You must be signed in to change notification settings - Fork 14.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gifski: mark as unbroken on darwin #180914
Conversation
Ofborg is unhappy with x86_64-darwin. |
Mmm, I use Big Sur (too old of a MacBook to upgrade now). I wonder if that matters. It does build on my machine: Full log
|
Marked as broken by NixOS#173671 but builds and works fine on darwin, with sandbox enabled.
ofborg aarch64-darwin missing issue should be fixed now but it needs a repush to work again |
If nobody else can confirm that it builds on Darwin, then I shall close this, I guess. But I see it building and working just fine. |
It's failing during checkPhase so you could disable them on darwin. If you have the time then could you search for why the error is happening. For the record here is the whole log
|
Done in #183958. |
Description of changes
Marked as broken by #173671, but it builds and works fine on darwin, with sandbox enabled.
Should be backported I guess.
Things done
sandbox = true
set innix.conf
? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)nixos/doc/manual/md-to-db.sh
to update generated release notes