Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sigal: fix build on darwin #180926

Merged
merged 1 commit into from
Jul 10, 2022
Merged

sigal: fix build on darwin #180926

merged 1 commit into from
Jul 10, 2022

Conversation

smancill
Copy link
Contributor

Description of changes

Disable failing test on darwin.

Marked as broken by #173671 I think, should be backported.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

Disable failing test.
@smancill
Copy link
Contributor Author

Result of nixpkgs-review pr 180926 run on x86_64-darwin 1

1 package built:
  • sigal

@Mindavi Mindavi merged commit fb3672f into NixOS:master Jul 10, 2022
@Mindavi
Copy link
Contributor

Mindavi commented Jul 10, 2022

Are you using stable?

@smancill
Copy link
Contributor Author

Are you using stable?

I'm sorry, I don't understand the question. I build on top of master.

Or it was supposed to be in another of my PR that you merged/reviewed, I guess #180923 (that failed to backport) or #180914 (not building on ofborg).

@Mindavi
Copy link
Contributor

Mindavi commented Jul 11, 2022

I was asking because you're asking for backports, so I wondered if that's more generic or specifically for your usecase :)

@smancill
Copy link
Contributor Author

No, I just read through the list of packages in #173671, that were marked as broken at the end of ZHF, to find some that I could fix and send PRs. That's why I said in my PRs that they should be backported, since nobody else fixed them before the end of ZHF.

@Mindavi
Copy link
Contributor

Mindavi commented Jul 12, 2022

Ah okay, thanks for going through some of those. Not sure if we'll backport everything, we'll see how that goes. For me there's more priority fixing master than anything else, but of course different users have different needs.

@smancill smancill deleted the sigal-darwin branch July 12, 2022 23:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants