Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python3Packages.mongomock: init at 3.23.0 #155419

Merged
merged 1 commit into from
Jan 18, 2022

Conversation

gador
Copy link
Member

@gador gador commented Jan 17, 2022

Motivation for this change

add mongomock, which is nedded by #155212

Note: This depends on #155418

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.05 Release Notes (or backporting 21.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.


propagatedBuildInputs = [
setuptools
pbr
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pbr is usually in nativeBuildInputs and not a run-time requirement. setuptools are also not mention in [requirements.txt](https://github.com/mongomock/mongomock/blob/3.23.0/requirements.txt]

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That depends on the usage. If pbr is used in the program itself which some openstack things do then it needs to be propagated.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't found any other reference to pbr except here
I'm not familiar with pbr, but looking at the documentation it seems, it is mainly (only?) used at build time.
I think its save to put it under nativeBuildInputs

pkgs/development/python-modules/mongomock/default.nix Outdated Show resolved Hide resolved
pkgs/development/python-modules/mongomock/default.nix Outdated Show resolved Hide resolved
pkgs/development/python-modules/mongomock/default.nix Outdated Show resolved Hide resolved
@SuperSandro2000
Copy link
Member

@ofborg eval

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).

Result of nixpkgs-review pr 155419 run on x86_64-linux 1

2 packages built:
  • python310Packages.mongomock
  • python39Packages.mongomock

@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 labels Jan 18, 2022
@SuperSandro2000 SuperSandro2000 merged commit 42d3974 into NixOS:master Jan 18, 2022
@gador gador deleted the add-mongomock branch January 18, 2022 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: python 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants