-
-
Notifications
You must be signed in to change notification settings - Fork 14.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
python3Packages.mongomock: init at 3.23.0 #155419
Conversation
|
||
propagatedBuildInputs = [ | ||
setuptools | ||
pbr |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pbr
is usually in nativeBuildInputs
and not a run-time requirement. setuptools
are also not mention in [requirements.txt
](https://github.com/mongomock/mongomock/blob/3.23.0/requirements.txt]
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That depends on the usage. If pbr is used in the program itself which some openstack things do then it needs to be propagated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't found any other reference to pbr except here
I'm not familiar with pbr, but looking at the documentation it seems, it is mainly (only?) used at build time.
I think its save to put it under nativeBuildInputs
@ofborg eval |
04a3aa5
to
e1fb406
Compare
This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch). Result of 2 packages built:
|
Motivation for this change
add mongomock, which is nedded by #155212
Note: This depends on #155418
Things done
sandbox = true
set innix.conf
? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)nixos/doc/manual/md-to-db.sh
to update generated release notes